Hi Peter, On Mon, Apr 24, 2017 at 10:03 AM, Peter De Schrijver <pdeschrijver@xxxxxxxxxx> wrote: >> > --- a/drivers/clk/renesas/rcar-gen3-cpg.c >> > +++ b/drivers/clk/renesas/rcar-gen3-cpg.c >> >> > +static unsigned long cpg_z_clk_recalc_rate(struct clk_hw *hw, >> > + unsigned long parent_rate) >> > +{ >> > + struct cpg_z_clk *zclk = to_z_clk(hw); >> > + unsigned int mult; >> > + unsigned int val; >> > + unsigned long rate; >> > + >> > + val = (clk_readl(zclk->reg) & CPG_FRQCRC_ZFC_MASK) >> > + >> CPG_FRQCRC_ZFC_SHIFT; >> > + mult = 32 - val; >> > + >> > + rate = div_u64((u64)parent_rate * mult + 16, 32); >> > + /* Round to closest value at 100MHz unit */ >> > + rate = 100000000*DIV_ROUND_CLOSEST(rate, 100000000); >> >> Mike, Stephen: what's your opinion about such rounding tricks? > > Is this an actual divider or a pulse skipper? Forgive my ignorance, but what is the difference? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds