Hi Uli, On Wed, Apr 19, 2017 at 3:24 PM, Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> wrote: > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > This patch enables PWM{1,2} for Salvator-X board on R8A7795 SoC. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> > --- > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts > index bf4674e..842b0dd 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts > @@ -282,6 +282,18 @@ > }; > }; > > +&pwm1 { > + pinctrl-0 = <&pwm1_pins>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&pwm2 { > + pinctrl-0 = <&pwm2_pins>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > &du { > pinctrl-0 = <&du_pins>; > pinctrl-names = "default"; > @@ -324,6 +336,16 @@ > pinctrl-0 = <&scif_clk_pins>; > pinctrl-names = "default"; > > + pwm1_pins: pwm1 { > + groups = "pwm1_a", "pwm1_b"; Enabling both the A and B alternative pins? > + function = "pwm1"; > + }; > + > + pwm2_pins: pwm2 { > + groups = "pwm2_a", "pwm2_b"; Enabling both the A and B alternative pins? > + function = "pwm2"; > + }; > + Oh, I wrote that before: http://www.spinics.net/lists/linux-renesas-soc/msg00026.html And we already have a correct v3 from you in patchwork: https://patchwork.kernel.org/patch/8711801/ And Laurent enabled backlight independently: https://lists.freedesktop.org/archives/dri-devel/2016-November/124385.html Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds