Hi Marek,
On Tue, Apr 18, 2017 at 9:05 PM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
> On 04/18/2017 03:59 PM, Geert Uytterhoeven wrote:
>> On Sun, Apr 16, 2017 at 6:57 PM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
>>> --- a/arch/arm/boot/dts/r8a7791.dtsi
>>> +++ b/arch/arm/boot/dts/r8a7791.dtsi
>>> @@ -776,6 +776,15 @@
>>> status = "disabled";
>>> };
>>>
>>> + adc: adc@e6e54000 {
>>> + compatible = "renesas,r8a7791-gyroadc", "renesas,rcar-gyroadc";
>>> + reg = <0 0xe6e54000 0 64>;
>>> + clocks = <&mstp9_clks R8A7791_CLK_GYROADC>, <&adc_clk>;
>>> + clock-names = "fck", "if";
>>> + power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
>>> + status = "disabled";
>>> + };
>>> +
>>> scif2: serial@e6e58000 {
>>> compatible = "renesas,scif-r8a7791", "renesas,rcar-gen2-scif",
>>> "renesas,scif";
>>> @@ -1133,6 +1142,13 @@
>>> clock-frequency = <0>;
>>> };
>>>
>>> + /* GyroADC clock */
>>> + adc_clk: adc_clk {
>>> + compatible = "fixed-clock";
>>> + #clock-cells = <0>;
>>> + clock-frequency = <65000000>;
>>> + };
>>
>> Why do you have to add a clock?
>> I think you should just refer to the on-SoC peripheral clock: &cp_clk.
>
> I think you are right, in fact, see below ...
>
>>> +
>>> /* Special CPG clocks */
>>> cpg_clocks: cpg_clocks@e6150000 {
>>> compatible = "renesas,r8a7791-cpg-clocks",
>>> @@ -1432,6 +1448,7 @@
>>> <&hp_clk>, <&hp_clk>;
>>
>> Missing addition of the parent clock for the newly added module clock.
>> Perhaps this should be the peripheral clock (<&cp_clk>)?
>>
>> Oops, that means there's no need to have two clock inputs in the adc device
>> node, and thus we screwed up when reviewing the GyroADC bindings :-(
>
> I think you're right. I should be just getting the clk rate of the fck
> and derive the gyroadc timings from that, correct ? I can send a patch
> for the driver to just ignore the second clock entry and update the DT
> binding document to drop the "if" clock (?) .
Fine for me. Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
