Re: [PATCH] ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sergei

> >  		/*
> > +		 * It will set SSIWSR.CONT here, but SSICR.CKDV = 000
> > +		 * with it is not allowed. (SSIWSR.WS_MODE with
> > +		 * SSICR.CKDV = 000 is not allowed either).
> > +		 * Skip it. See SSICR.CKDV
> > +		 */
> > +		if (j == 0)
> > +			continue;
> 
>    Why not change the *for* statement itself to start with j = 1?

It can be one solution. Actually my local 1st patch was such style.
But I thought that it is difficult to notice such magical operation from code.
Thus, I used this style

Best regards
---
Kuninori Morimoto



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux