Re: [PATCH v4 2/2] clocksource: Add renesas-ostm timer driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 25, 2017 at 09:07:07PM -0500, Chris Brandt wrote:
> This patch adds a OSTM driver for the Renesas architecture.
> The OS Timer (OSTM) has independent channels that can be
> used as a freerun or interval times.
> This driver uses the first probed device as a clocksource
> and then any additional devices as clock events.
> 
> Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>
> ---
> v3:
> * Added more details to commit log
> * Kconfig: SYS_SUPPORTS_RENESAS_OSTM to just RENESAS_OSTM
> * removed all MODULE code (this driver is builtin only)
> * removed items from 'struct ostm_device'
> * changed ioread8 to readb

The iowrite* conversion is missing.

s/iowrite8/writeb/
s/iowrite32/writel/

Other than that the driver looks good to me.

Thanks.

  -- Daniel



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux