On Mon, Jan 23, 2017 at 10:11:20AM +0100, Geert Uytterhoeven wrote: > Hi Sergei, > > On Fri, Jan 20, 2017 at 5:21 PM, Sergei Shtylyov > <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > > On 01/20/2017 04:04 PM, Geert Uytterhoeven wrote: > > > >> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > >> --- > >> arch/arm/mach-shmobile/pm-rcar-gen2.c | 40 > >> +++++++++++++++++++++++++---------- > >> 1 file changed, 29 insertions(+), 11 deletions(-) > >> > >> diff --git a/arch/arm/mach-shmobile/pm-rcar-gen2.c > >> b/arch/arm/mach-shmobile/pm-rcar-gen2.c > >> index dd9ac366868f4336..6ed9aa19c4d34766 100644 > >> --- a/arch/arm/mach-shmobile/pm-rcar-gen2.c > >> +++ b/arch/arm/mach-shmobile/pm-rcar-gen2.c > >> @@ -20,14 +20,30 @@ > > > > [...] > >> > >> +static inline u32 phys_to_sbar(phys_addr_t addr) > >> +{ > >> + return (((addr) >> 8) & 0xfffffc00); > > > > > > It's not a macro -- innermost parens not needed... > > Thanks, outermost neither ;-) Geert, I'm assuming you will respin this. Let me know if that is not the case.