Hi Sergei, On Fri, Jan 20, 2017 at 5:21 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > On 01/20/2017 04:04 PM, Geert Uytterhoeven wrote: > >> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> --- >> arch/arm/mach-shmobile/pm-rcar-gen2.c | 40 >> +++++++++++++++++++++++++---------- >> 1 file changed, 29 insertions(+), 11 deletions(-) >> >> diff --git a/arch/arm/mach-shmobile/pm-rcar-gen2.c >> b/arch/arm/mach-shmobile/pm-rcar-gen2.c >> index dd9ac366868f4336..6ed9aa19c4d34766 100644 >> --- a/arch/arm/mach-shmobile/pm-rcar-gen2.c >> +++ b/arch/arm/mach-shmobile/pm-rcar-gen2.c >> @@ -20,14 +20,30 @@ > > [...] >> >> +static inline u32 phys_to_sbar(phys_addr_t addr) >> +{ >> + return (((addr) >> 8) & 0xfffffc00); > > > It's not a macro -- innermost parens not needed... Thanks, outermost neither ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds