Hi Geert,
On 10/01/2017 16:07, Geert Uytterhoeven wrote:
Hi Jacopo,
On Mon, Jan 9, 2017 at 8:31 PM, Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote:
From: Magnus Damm <damm@xxxxxxxxxxxxx>
This is a squash of several commits, adding peripherals groups
configuration to r7s72100 device tree, and enabling some of them on
Genmai evaluation board
Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
Thanks for the rework!
arch/arm/boot/dts/r7s72100-genmai.dts | 51 ++++++++++++
arch/arm/boot/dts/r7s72100.dtsi | 151 ++++++++++++++++++++++++++++++++++
This path should be split in multiple parts:
- Add the pfc node to r7s72100.dtsi,
- Add the gpio nodes to r7s72100.dtsi,
- 4 patches for r7s72100-genmai.dts, adding support for LEDs, SCIF,
Ethernet, and SPI.
I can easily separate the last 4 patches, but I don't feel like breaking
in 2 parts the original patch that adds both pfc and gpio nodes to the
.dtsi file.
This will look like:
- Add pfc and gpio nodes to r7s72100.dtsi
- 4 patches to add LEDs, SCIF, ETH and SPI to r7s72100-genmai.dts
Hope this is ok
Thanks
j
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -20,6 +20,19 @@
#size-cells = <1>;
aliases {
+ gpio0 = &port0;
+ gpio1 = &port1;
+ gpio2 = &port2;
+ gpio3 = &port3;
+ gpio4 = &port4;
+ gpio5 = &port5;
+ gpio6 = &port6;
+ gpio7 = &port7;
+ gpio8 = &port8;
+ gpio9 = &port9;
+ gpio10 = &port10;
+ gpio11 = &port11;
+ gpio12 = &jtagport0;
Please remove this hunk.
GPIO aliases are deprecated, and I don't think the driver uses them.
i2c0 = &i2c0;
i2c1 = &i2c1;
i2c2 = &i2c2;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds