Hi Laurent,
On Wed, Jan 4, 2017 at 12:06 AM, Laurent Pinchart
<laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote:
> The regshift value is computed automatically by the driver, there's no
> need to set it in platform data. Specify the associated memory resource
> lengths to ensure proper computation of the value.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
Doing this separate from "[PATCH 19/19] serial: sh-sci: Compute the regshift
value for SCI ports") breaks bisection.
> --- a/arch/sh/kernel/cpu/sh4/setup-sh7760.c
> +++ b/arch/sh/kernel/cpu/sh4/setup-sh7760.c
> @@ -201,12 +201,18 @@ static struct platform_device scif2_device = {
>
> static struct plat_sci_port scif3_platform_data = {
> .scscr = SCSCR_REIE,
> + /*
> + * This is actually a SIM card module serial port, based on an SCI with
> + * additional registers. The sh-sci driver doesn't support the SIM port
> + * type, declare it as a SCI. Don't declare the additional registers in
> + * the memory resource or the driver will compute an incorrect regshift
> + * value.
> + */
> .type = PORT_SCI,
> - .regshift = 2,
Yeah, that regshift value doesn't match the datasheet at all
(should have been 1 before).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
