Hi Geert and Morimoto-san, On December 15, 2016, Geert Uytterhoeven wrote: > Or you can add an of_device_is_compatible(np, "renesas,r7s72100-mstp- > clocks") check to cpg_mstp_clocks_init(), keeping the single > CLK_OF_DECLARE(). > > I think that would also performs slightly better, as only nodes compatible > with "renesas,cpg-mstp-clocks" would be subject to the additional check. > I think now I am leaning more towards that idea: * use of_device_is_compatible(np, "renesas,r7s72100-mstp-clocks") * add reg_width_8bit to group (not global) The reason is that I HOPE that this one SOC will be the only Renesas device that will ever have 8-bit MSTP registers. All the other MPU devices seem to have 32-bit. Therefore, adding a simple 1-line of_device_is_compatible for this one case seems the best. Thank you for the suggestions. Chris
