Re: [PATCH v2] sh_eth: remove unchecked interrupts

Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> · Thu, 1 Dec 2016 20:37:51 +0300

On 12/01/2016 05:42 PM, Geert Uytterhoeven wrote:

--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -518,7 +518,7 @@ static struct sh_eth_cpu_data r7s72100_data = {

        .ecsr_value     = ECSR_ICD,
        .ecsipr_value   = ECSIPR_ICDIP,
-       .eesipr_value   = 0xff7f009f,
+       .eesipr_value   = 0xe77f009f,

Comment not directly related to the merits of this patch: the EESIPR bit
definitions seem to be identical to those for EESR, so we can get rid of the
hardcoded values here?

   Do you mean using the @define's? We have EESIPR bits also declared, see 
enum DMAC_IM_BIT,

[...]

MBR, Sergei







