Hi Chris, On Thu, Dec 1, 2016 at 3:06 PM, Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote: > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -518,7 +518,7 @@ static struct sh_eth_cpu_data r7s72100_data = { > > .ecsr_value = ECSR_ICD, > .ecsipr_value = ECSIPR_ICDIP, > - .eesipr_value = 0xff7f009f, > + .eesipr_value = 0xe77f009f, Comment not directly related to the merits of this patch: the EESIPR bit definitions seem to be identical to those for EESR, so we can get rid of the hardcoded values here? > > .tx_check = EESR_TC1 | EESR_FTC, > .eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT | Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds