Re: [PATCH 6/9 v2] arm64: dts: m3ulcb: enable SDHI0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

On 09.11.2016 10:44, Simon Horman wrote:
On Tue, Nov 08, 2016 at 05:14:21PM +0300, Vladimir Barinov wrote:
This supports SDHI0 on M3ULCB board SD card slot

Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
Reviewed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
Thanks Vladimir,

I have queued up the following patches:

arm64: dts: h3ulcb: rename SDHI0 pins
arm64: dts: h3ulcb: enable SDHI2
arm64: dts: m3ulcb: enable SDHI2
arm64: dts: m3ulcb: enable SDHI0

For reference I would, however, like to make some comments regarding the
way you have submitted these:

1. I did not provide a Reviewed-off-by tag or any other tag as far as I
    recall. So its not appropriate for you to add one when posting patches.
    I have removed it.

2. Not withstanding the above, Reviewed-off-by is an invalid tag.
    Perhaps you mean Reviewed-by.

3. When you repost patches I have a slight preference for you to repost
    them in a fresh thread. And if the patchset has more than one patch then
    with a fresh cover letter. This makes it a little easier for me
    to see what is going on. And gives a more natural place for
    me to respond to a patchset.

Thank you for these valuable comments!

I will follow them for further work.


Regards,

Vladimir




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux