On Tue, Nov 08, 2016 at 11:07:58AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, Nov 8, 2016 at 11:02 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > > On Mon, Nov 07, 2016 at 07:53:04PM +0100, Geert Uytterhoeven wrote: > >> On Wed, Oct 26, 2016 at 4:14 PM, Ulrich Hecht > >> <ulrich.hecht+renesas@xxxxxxxxx> wrote: > >> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> > >> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > >> > --- > >> > arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 12 ++++++++++++ > >> > 1 file changed, 12 insertions(+) > >> > > >> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > >> > index 8255c56..e48de7c 100644 > >> > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > >> > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts > >> > @@ -111,6 +111,11 @@ > >> > function = "scif_clk"; > >> > }; > >> > > >> > + i2c2_pins: i2c2 { > >> > + groups = "i2c2_a"; > >> > + function = "i2c2"; > >> > + }; > >> > + > >> > sdhi0_pins: sd0 { > >> > groups = "sdhi0_data4", "sdhi0_ctrl"; > >> > function = "sdhi0"; > >> > >> BTW, do we have a policy about (alphabetical) ordering? > > > > FWIW I think we should aim to have notes sorted by a) base address and > > b) alphabetically. > > I think "nodes" comes first, before "notes" ;-) Yes, that's the spirit.