RE: [PATCH 2/2] regmap: Avoid namespace collision within macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Thu, Oct 27, 2016 at 10:33:19AM +0100, Ramesh Shanmugasundaram wrote:
> 
> >  #define regmap_read_poll_timeout(map, addr, val, cond, sleep_us,
> > timeout_us) \  ({ \
> > -	ktime_t timeout = ktime_add_us(ktime_get(), timeout_us); \
> > +	ktime_t __timeout = ktime_add_us(ktime_get(), timeout_us); \
> >  	int ret; \
> 
> Why is timeout an issue and not ret?

It is! However, it is less likely for someone to use "ret" as a variable name for the given parameter list. Hence, I fixed timeout alone. Feel free to fix "ret" as well. 

Thanks,
Ramesh




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux