On Fri, Oct 21, 2016 at 10:17 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > --- /dev/null > +++ linux/drivers/clk/renesas/r8a7743-cpg-mssr.c > @@ -0,0 +1,264 @@ > +static int __init r8a7743_cpg_mssr_init(struct device *dev) > +{ > + const struct rcar_gen2_cpg_pll_config *cpg_pll_config; > + u32 cpg_mode = rcar_gen2_read_modemr(); It would be good if we could appply "[PATCH v4 00/23] soc: renesas: Add R-Car RST driver for obtaining mode pin state" first, and change this driveer to use rcar_rst_read_mode_pins() instead. > + cpg_pll_config = &cpg_pll_configs[CPG_PLL_CONFIG_INDEX(cpg_mode)]; > + > + return rcar_gen2_cpg_init(cpg_pll_config); > +} Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds