Hi Chris, On Mon, Aug 29, 2016 at 5:32 PM, Chris Brandt <Chris.Brandt@xxxxxxxxxxx> wrote: > On Aug 29, 2016, Geert Uytterhoeven wrote: >> We really need to get the GPIO driver upstream, and add support for reading the MD_* pins. > > OK, we can just read the mode pin instead of looking at the DT. > > In setup-r8a7779.c, they use ioremap to read the mode and then pass the mode into r8a7779_clocks_init() in the clock file. > Looks like setup-rcar-gen2.c does the same thing. > > So, can we do the same in setup-r7s72100.c and clk-rz.c? No GPIO driver is needed and it would match the other platforms are doing. Please don't: we're trying to get rid of reading the mode pins (a) in setup-*.c and passing them to the clock driver, (b) without a proper driver. Until you have a proper GPIO driver, I think the best solution is to ioremap() the hardcoded registers in clk-rz.c, and reading the mode pins. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds