On Friday 10 Jun 2016 09:58:28 Geert Uytterhoeven wrote: > Hi Dirk, > > On Thu, Jun 2, 2016 at 7:42 AM, Dirk Behme <dirk.behme@xxxxxxxxxxxx> wrote: > >> +int __init rcar_rst_read_mode_pins(u32 *mode) > > > > Just a style issue: Is the string 'pins' in the function name still > > relevant? I.e. what's about just 'rcar_rst_read_mode()'? > > I feel "mode" is a too generic word for a public API. > It's used a several contexts inside the RST module (secure mode, 64-bit > addressing mode, free-running mode, step-up mode). <bikeshedding> If it's "pins" that bothers Dirk, how about rcar_rst_read_boot_mode() ? Or maybe rcar_rst_boot_mode(), given that the function caches the value, it doesn't read it every time. </bikeshedding> -- Regards, Laurent Pinchart
