On 10.06.2016 09:58, Geert Uytterhoeven wrote:
Hi Dirk,
On Thu, Jun 2, 2016 at 7:42 AM, Dirk Behme <dirk.behme@xxxxxxxxxxxx> wrote:
+int __init rcar_rst_read_mode_pins(u32 *mode)
Just a style issue: Is the string 'pins' in the function name still
relevant? I.e. what's about just 'rcar_rst_read_mode()'?
I feel "mode" is a too generic word for a public API.
It's used a several contexts inside the RST module (secure mode, 64-bit
addressing mode, free-running mode, step-up mode).
What's about
rcar_rst_read_mode_monitor()
then?
Taken from the manual ;)
Best regards
Dirk
