Re: [PATCH 09/10] ARM: r8a779x: Add boot mode reg support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On 09.05.2016 09:54, Geert Uytterhoeven wrote:
Hi Dirk,

On Mon, May 9, 2016 at 9:52 AM, Dirk Behme <dirk.behme@xxxxxxxxxxxx> wrote:
On 09.05.2016 09:44, Geert Uytterhoeven wrote:

On Mon, May 9, 2016 at 9:14 AM, Dirk Behme <dirk.behme@xxxxxxxxxxxx>
wrote:

--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -1102,6 +1102,11 @@
                        #power-domain-cells = <0>;
                };

+               modemr: modemr@e6160060 {
+                       compatible = "renesas,modemr";
+                       reg = <0 0xe6160060 0 0x4>;
+               };
+


This should be a node for the complete RST module, not just for the RST
module's
MODEMR register.



You mean

reset: reset@e6160000 {
        compatible = "renesas,reset";
        reg = <0 0xe6160000 0 0x200>;
};

and then use anything like

#define MODEMR 0x60

in the code?

Yes, more or less:

        reset-controller@e6160000 {
                compatible = "renesas,r8a7795-rst";


Hmm, do we really want the r8a7795 here? Then we would need

r8a7790-rst
r8a7791-rst
r8a7792-rst
r8a7793-rst
r8a7794-rst
r8a7795-rst
r8a7796-rst
...

?


Best regards

Dirk



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux