Hi Christoph, On 2016-04-25 12:10:04 -0700, Christoph Hellwig wrote: > On Mon, Apr 25, 2016 at 04:26:19PM +0200, Niklas S?derlund wrote: > > I have followed the call path from the usage in > > drivers/dma/sh/rcar-dmac.c and made sure the dma_addr_t is not used in a > > bad way. > > The dma-debug routines are called from the generic code in > include/linux/dma-mapping.h, and from my reading of the other patches > in your series you are calling it for these as well. You are correct I have not consider that dma_mapping_error() call in to lib/dma-debug.c. I will see if I can make the dma_mapping_error() safe to use with a dma_addr_t obtained from dma_map_resource() and post a new series. Thanks for pointing this out! -- Regards, Niklas Söderlund