Re: [PATCH v2 2/9] mmc: tmio, sh_mobile_sdhi: Add support for variable input clock frequency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 17, 2016 at 2:49 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> On Fri, Apr 15, 2016 at 10:41:57PM +0200, Wolfram Sang wrote:
>> > > That seems like a bug in the clock driver.  If it doesn't have
>> > > independent dividers for each clock client then it shouldn't allow any
>> > > client to change the frequency.
>>
>> So, we need MSTP clocks which do not use CLK_SET_RATE_PARENT on r8a7740.
>> Probably the best way is to use the "renesas,r8a7740-mstp-clocks"
>> compatible entry to determine the difference? Geert?
>
> Well, I like the idea of a virtual sd clock even better. I sent a series
> doing that a minute ago to the renesas-soc list.

While I don't doubt the "virtual sd" clock will work, this doesn't match the
hardware, so I have to object against it.

Hence I think it should be handled in the driver. This is indeed more difficult
to do with clk-mstp.c than with renesas-cpg-mssr.c...

BTW, this behavior seems to be introduced by
commit e44df332f30bf3040c60c1ed6674d1431fdb48b9
Author: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
Date:   Mon Mar 31 18:47:27 2014 +0100

    clk: shmobile: fix setting paretn clock rate

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux