Hi Wolfram, On Mon, Apr 18, 2016 at 8:46 AM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: >> Can you please give more detail about this r8a7740 issue? Just >> "r8a7740 flaw" does not make me understand. > > Ah, sorry. This RFC series was merely meant as a "right direction?" > series for Geert, thus the short CC list. The full series will have > better documentation. > > The flaw is: On r8a7740, the MSTP clocks for SDHI have HP directly as > their parent. With my updates, SDHI driver changes clock rates. HP clock > shouldn't be changed since other IP cores are connected to it. So, this > solution puts a fixed-factor (1:1) "sd" clock between HP and SDHI MSTP. Thanks for your series! While I don't doubt your approach will work, this "virtual sd" clock doesn't match the hardware, so I have to object against it. Hence I think it should be handled in the driver. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds