Re: [PATCH 1/2] fbdev: sh_mobile_meram: use ARCH_RENESAS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 11, 2016 at 08:55:36AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Mar 11, 2016 at 3:28 AM, Simon Horman
> <horms+renesas@xxxxxxxxxxxx> wrote:
> > Use ARCH_RENESAS in place of ARCH_SHMOBILE.
> > Also remove spurious ().
> >
> > This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
> > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
> >
> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> > ---
> >  drivers/video/fbdev/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > index 8ea45a5cd806..71294f595f61 100644
> > --- a/drivers/video/fbdev/Kconfig
> > +++ b/drivers/video/fbdev/Kconfig
> > @@ -1985,7 +1985,7 @@ config FB_W100
> >
> >  config FB_SH_MOBILE_LCDC
> >         tristate "SuperH Mobile LCDC framebuffer support"
> > -       depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
> > +       depends on FB && (SUPERH || ARCH_RENESAS) && HAVE_CLK
> 
> I would replace SUPERH by ARCH_RENESAS, and thus keep ARCH_SHMOBILE.
> 
> "sh_mobile_lcdc_fb" is used on SH_AP325RXA, SH_ECOVEC, SH_KFR2R09, SH_MIGOR,
> and SH_7724_SOLUTION_ENGINE, which depend on either CPU_SUBTYPE_SH7722,
> CPU_SUBTYPE_SH7723, or CPU_SUBTYPE_SH7724, and all three select ARCH_SHMOBILE.
> 
> In addition, it's used on r8a7740/armadillo800eva, which is covered by
> ARCH_RENESAS.
> 
> >         depends on FB_SH_MOBILE_MERAM || !FB_SH_MOBILE_MERAM
> >         select FB_SYS_FILLRECT
> >         select FB_SYS_COPYAREA
> > @@ -2450,7 +2450,7 @@ source "drivers/video/fbdev/mmp/Kconfig"
> >
> >  config FB_SH_MOBILE_MERAM
> >         tristate "SuperH Mobile MERAM read ahead support"
> > -       depends on (SUPERH || ARCH_SHMOBILE)
> > +       depends on SUPERH || ARCH_RENESAS
> >         select GENERIC_ALLOCATOR
> >         ---help---
> >           Enable MERAM support for the SuperH controller.
> 
> As Laurent already pointed out, that one is currently unused.
> 
> It could be used on sh73a0, r8a7740, and some SuperH SH-Mobile SoCs, though.

I'm inclined to remove the driver if its unused (I assume that has
been the case for quite some time).



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux