Re: [PATCH v3 5/7] soc: renesas: Add r8a7793 SYSC PM Domain Binding Definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

On Thu, Mar 10, 2016 at 7:59 AM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> On Wednesday 09 March 2016 20:18:40 Geert Uytterhoeven wrote:
>> R-Car M2-N is identical to R-Car M2-W w.r.t. power domains, so reuse the
>> definitions from the latter.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

>> --- /dev/null
>> +++ b/include/dt-bindings/power/r8a7793-sysc.h
>> @@ -0,0 +1,27 @@
>> +/*
>> + * Copyright (C) 2016 Glider bvba
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; version 2 of the License.
>> + */
>> +#ifndef __DT_BINDINGS_POWER_R8A7793_SYSC_H__
>> +#define __DT_BINDINGS_POWER_R8A7793_SYSC_H__
>> +
>> +/*
>> + * These power domain indices match the numbers of the interrupt bits
>> + * representing the power areas in the various Interrupt Registers
>> + * (e.g. SYSCISR, Interrupt Status Register)
>> + *
>> + * R-Car M2-N is identical to R-Car M2-W w.r.t. power domains.
>> + */
>> +
>> +#include "r8a7791-sysc.h"
>> +
>> +#define R8A7793_PD_CA15_CPU0         R8A7791_PD_CA15_CPU0
>> +#define R8A7793_PD_CA15_CPU1         R8A7791_PD_CA15_CPU1
>> +#define R8A7793_PD_CA15_SCU          R8A7791_PD_CA15_SCU
>> +#define R8A7793_PD_SH                        R8A7791_PD_SH
>> +#define R8A7793_PD_SGX                       R8A7791_PD_SGX
>
> I would use numbers directly without including r8a7791-sysc.h, it would save
> going through yet another file when looking for the numerical value.

My main motivation of doing it this way is that r8a7791-sysc.c is also used
on r8a7793, and thus uses the R8A7791_PD_* values directly.

But if you prefer it this way, I can make that change.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux