Hi Simon, On Wed, Feb 17, 2016 at 9:08 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Wed, Feb 17, 2016 at 03:45:19PM +0900, Magnus Damm wrote: >> $ grep "renesas," Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt >> - compatible: "renesas,dmac-<soctype>", "renesas,rcar-dmac" as fallback. >> - "renesas,dmac-r8a7790" (R-Car H2) >> - "renesas,dmac-r8a7791" (R-Car M2-W) >> - "renesas,dmac-r8a7792" (R-Car V2H) >> - "renesas,dmac-r8a7793" (R-Car M2-N) >> - "renesas,dmac-r8a7794" (R-Car E2) >> - "renesas,dmac-r8a7795" (R-Car H3) >> compatible = "renesas,dmac-r8a7790", "renesas,rcar-dmac"; >> compatible = "renesas,dmac-r8a7790", "renesas,rcar-dmac"; >> $ > > It looks like I have been making the mess worse :( > > Possibly I prepared the patch in question, though recently, > before I was properly aware of the preferred order. No worries! The code above is at least consistent and matches the common current case. >> No need to rework existing stuff IMO. However once we rework DT >> bindings (CMT) or add new ones (SYS-DMAC) then we have a good >> opportunity to clean things up. > > Understood. From my point of view that seems like an opportunity worth taking. So shall we leave the SYS-DMAC as-is or change things around? I personally don't see the point in redoing things just to change order, so keep as-is sounds good to me. For the "fallback" CMT DT compat strings I think we should follow the proposal from Geert and go with "renesas,rcar-gen2-cmt0". Regarding the per-soc CMT DT compat strings my feeling is that we should follow the same order as SYS-DMAC to keep things consistent. Thanks, / magnus
