Hi Niklas, On Monday 22 February 2016 15:36:16 Niklas Söderlund wrote: > On 2016-02-22 14:31:29 +0100, Ulrich Hecht wrote: > > On Sun, Feb 14, 2016 at 5:55 PM, Niklas Söderlund > > > > <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > > > Also I > > > could only get frames if the video signal on the composite IN was NTSC, > > > but this also applied to the soc_camera driver, it might be my test > > > setup. > > > > I think it is. For me, PAL works just as well as NTSC. > > Yes it must have been my setup, I'm now using a PAL SNES as my video > source and it works fine. I'm about ready to send out a v2 of this patch > with all of Hans comments fixed. I only need to look at > vidioc_[gs]_selection. I think we need an SNES screenshot as a proof ;-) > It took some extra time since I found some bugs in how I handled DMA and > that I had been to libera in porting the format code from soc-camera. > It's all fixed and all v4l2-compliance tests I tried works. > > One concern I have is that I can't get some of the formats to display > properly in qv4l2 (V4L2_PIX_FMT_NV16, V4L2_PIX_FMT_RGB555X, > V4L2_PIX_FMT_RGB32) but I get the same 'errors' in the feed as I do with > the soc-camera driver so I'm not spending so much time on the issue right > now. What errors do you get ? > Unfortunate the rework I have done clashes with your HDMI series Ulrich. > If you wish I can rework the parts of your series that touches rcar-vin > and post them as a separate series after v2? Let me know what you think. -- Regards, Laurent Pinchart
