Re: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shimoda-san,

[dropping most CCs to avoid delaying your patch]

On Thu, Jan 7, 2016 at 10:16 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> Since the related driver (CPG/MSSR driver) only manages the first module
> clock, this driver should not handle the HSUSB registers. So, this patch
> removes the HSUSB registers handling.

> --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt

>  Example (R-Car H3):
>
>         usb-phy@ee080200 {
>                 compatible = "renesas,usb2-phy-r8a7795";
> -               reg = <0 0xee080200 0 0x700>, <0 0xe6590100 0 0x100>;
> -               reg-names = "usb2_host", "hsusb";
> +               reg = <0 0xee080200 0 0x700>;
>                 interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> -               clocks = <&mstp7_clks R8A7795_CLK_EHCI0>,
> -                        <&mstp7_clks R8A7795_CLK_HSUSB>;
> +               clocks = <&mstp7_clks R8A7795_CLK_EHCI0>;
>         };
>
>         usb-phy@ee0a0200 {
>                 compatible = "renesas,usb2-phy-r8a7795";
>                 reg = <0 0xee0a0200 0 0x700>;
> -               reg-names = "usb2_host";
>                 clocks = <&mstp7_clks R8A7795_CLK_EHCI0>;
>         };

BTW, I think the examples should be updated to use the CPG/MSSR DT
bindings. That can/should be done in a separate patch, of course.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux