On 02/12/2022 11:33, Neil Armstrong wrote: >>> + >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - qcom,sm8550-cdsp-pas >>> + then: >>> + properties: >>> + power-domains: >>> + items: >>> + - description: CX power domain >>> + - description: MXC power domain >>> + power-domain-names: >>> + items: >>> + - const: cx >>> + - const: mxc >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - qcom,sm8550-cdsp-pas >> >> This entire if does not look valid - compatible is covered in the >> previous one. You should see `dtbs_check` warnings on your DTS. > > Wow indeed, this should be mpss-pas... Then also drop "contains" to match other places (and other files). > > The main changes here was firmware-name and memory-region to handle > the dtb firmware and the DSM memory region, are those OK ? > Yes. Best regards, Krzysztof
