On 30/11/2022 11:29, Neil Armstrong wrote: > This documents the compatible for the component used to boot the > aDSP, cDSP and MPSS on the SM8550 SoC. > > The SM8550 boot process on SM8550 now requires a secondary "Devicetree" > firmware to be passed along the main Firmware, and the cDSP a new power > domain named "NSP". > > A third memory domain for the DSM memory zone is also needed for the MPSS > PAS bindings. > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> Thank you for your patch. There is something to discuss/improve. > + > + - if: > + properties: > + compatible: > + enum: > + - qcom,sm8550-adsp-pas > + then: > + properties: > + power-domains: > + items: > + - description: LCX power domain > + - description: LMX power domain > + power-domain-names: > + items: > + - const: lcx > + - const: lmx > + > + - if: > + properties: > + compatible: > + enum: > + - qcom,sm8550-cdsp-pas > + then: > + properties: > + power-domains: > + items: > + - description: CX power domain > + - description: MXC power domain > + power-domain-names: > + items: > + - const: cx > + - const: mxc > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm8550-cdsp-pas This entire if does not look valid - compatible is covered in the previous one. You should see `dtbs_check` warnings on your DTS. > + then: > + properties: > + power-domains: > + items: > + - description: CX power domain > + - description: MXC power domain > + - description: NSP power domain > + power-domain-names: > + items: > + - const: cx > + - const: mxc > + - const: nsp > + > +unevaluatedProperties: false > + Best regards, Krzysztof
