> Subject: Re: [PATCH 1/9] dt-bindings: remoteproc: imx_rproc: support > i.MX8QXP > > On Tue, Jan 11, 2022 at 11:33:25AM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@xxxxxxx> > > > > Add i.MX8QXP compatible > > > > Add a new property rsrc-id for SoC which supports SCFW. This rsrc-id > > You are introducing an acronym that doesn't have a definition - I have to grep > the kernel tree to have an idea of what SCFW is. That consumes time that I > don't have to review your code or someone else's. Sorry. SCFW(System controller Unit Firmware). > > > is used to check whether remote process is under control of Linux or > > s/process/processor Fix in v2. Thanks, Peng. > > > not. > > > > To i.MX8QM/QXP, when M4 is in the same hardware partition with > > Cortex-A cores, need power up M4 through SCFW, then M4 could start. So > > introduce power-domains property > > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > > --- > > .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 10 > > ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > > b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > > index fc16d903353e..ed1bcb3046a9 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > > @@ -19,6 +19,7 @@ properties: > > - fsl,imx8mm-cm4 > > - fsl,imx8mn-cm7 > > - fsl,imx8mp-cm7 > > + - fsl,imx8qxp-cm4 > > - fsl,imx8ulp-cm33 > > - fsl,imx7d-cm4 > > - fsl,imx7ulp-cm4 > > @@ -59,6 +60,15 @@ properties: > > Indicate whether need to load the default firmware and start the > remote > > processor automatically. > > > > + power-domains: > > + maxItems: 8 > > + > > + rsrc-id: > > + description: > > + This property is to specify the resource id of the remote processor > in SoC > > + which supports SCFW > > + maxItems: 1 > > + > > required: > > - compatible > > > > -- > > 2.25.1 > >
