On Wed 03 Mar 14:01 CST 2021, Siddharth Gupta wrote:
> From: Raghavendra Rao Ananta <rananta@xxxxxxxxxxxxxx>
>
> For security reasons scnprintf() is preferred over sprintf().
> Hence, convert the remoteproc's sysfs show functions accordingly.
>
Thanks for the patch Siddharth.
There's no possibility for these calls to generate more than PAGE_SIZE
amount of data, so this isn't really necessary. But if you insist,
please let's use sysfs_emit() instead.
Regards,
Bjorn
> Signed-off-by: Raghavendra Rao Ananta <rananta@xxxxxxxxxxxxxx>
> Signed-off-by: Siddharth Gupta <sidgup@xxxxxxxxxxxxxx>
> ---
> drivers/remoteproc/remoteproc_sysfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c
> index 1dbef89..853f569 100644
> --- a/drivers/remoteproc/remoteproc_sysfs.c
> +++ b/drivers/remoteproc/remoteproc_sysfs.c
> @@ -15,7 +15,8 @@ static ssize_t recovery_show(struct device *dev,
> {
> struct rproc *rproc = to_rproc(dev);
>
> - return sprintf(buf, "%s", rproc->recovery_disabled ? "disabled\n" : "enabled\n");
> + return scnprintf(buf, PAGE_SIZE, "%s",
> + rproc->recovery_disabled ? "disabled\n" : "enabled\n");
> }
>
> /*
> @@ -82,7 +83,7 @@ static ssize_t coredump_show(struct device *dev,
> {
> struct rproc *rproc = to_rproc(dev);
>
> - return sprintf(buf, "%s\n", rproc_coredump_str[rproc->dump_conf]);
> + return scnprintf(buf, PAGE_SIZE, "%s\n", rproc_coredump_str[rproc->dump_conf]);
> }
>
> /*
> --
> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
