On Mon, Jan 25, 2021 at 05:56:52PM -0600, Suman Anna wrote:
> Update the existing OMAP HwSpinlock binding to include the info for
> AM64x SoCs. There are some minor IP integration differences between
> the AM64x SoCs and the previous AM65x and J721E SoC families. A new
> example is also added showcasing the difference in the IP's presence
> on the interconnect.
>
> Signed-off-by: Suman Anna <s-anna@xxxxxx>
> ---
> .../bindings/hwlock/ti,omap-hwspinlock.yaml | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> index ac35491a6f65..ac146c0d628f 100644
> --- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> +++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> @@ -14,6 +14,7 @@ properties:
> enum:
> - ti,omap4-hwspinlock # for OMAP44xx, OMAP54xx, AM33xx, AM43xx, DRA7xx SoCs
> - ti,am654-hwspinlock # for K3 AM65x, J721E and J7200 SoCs
> + - ti,am64-hwspinlock # for K3 AM64x SoCs
>
> reg:
> maxItems: 1
> @@ -74,3 +75,28 @@ examples:
> };
> };
> };
> +
> + - |
> + / {
> + /* K3 AM64x SoCs */
> + model = "Texas Instruments K3 AM642 SoC";
> + compatible = "ti,am642-evm", "ti,am642";
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + bus@f4000 {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges = <0x00 0x000f4000 0x00 0x000f4000 0x00 0x000002d0>, /* PINCTRL */
> + <0x00 0x01000000 0x00 0x01000000 0x00 0x02330400>, /* First peripheral window */
> + <0x00 0x0f000000 0x00 0x0f000000 0x00 0x00c44200>, /* Second peripheral window */
> + <0x00 0x20000000 0x00 0x20000000 0x00 0x0a008000>; /* Third peripheral window */
> +
> + spinlock@2a000000 {
Why are you doing the whole hierarchy here? Don't do that.
In any case, a new compatible doesn't warrant a whole new example, so
drop the example.
> + compatible = "ti,am64-hwspinlock";
> + reg = <0x00 0x2a000000 0x00 0x1000>;
> + #hwlock-cells = <1>;
> + };
> + };
> + };
> --
> 2.29.2
>
