On Wed, Dec 16, 2020 at 9:55 AM Grzegorz Jaszczyk <grzegorz.jaszczyk@xxxxxxxxxx> wrote: > > Hi Rob, > > On Mon, 14 Dec 2020 at 23:58, Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Fri, Dec 11, 2020 at 03:29:29PM +0100, Grzegorz Jaszczyk wrote: > > > From: Suman Anna <s-anna@xxxxxx> > > > > > > Add a YAML binding document for PRU consumers. The binding includes > > > all the common properties that can be used by different PRU consumer > > > or application nodes and supported by the PRU remoteproc driver. > > > These are used to configure the PRU hardware for specific user > > > applications. > > > > > > The application nodes themselves should define their own bindings. > > > > > > Co-developed-by: Tero Kristo <t-kristo@xxxxxx> > > > Signed-off-by: Tero Kristo <t-kristo@xxxxxx> > > > Signed-off-by: Suman Anna <s-anna@xxxxxx> > > > Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@xxxxxxxxxx> > > > Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@xxxxxxxxxx> > > > --- > > > .../bindings/remoteproc/ti,pru-consumer.yaml | 64 +++++++++++++++++++ > > > 1 file changed, 64 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > > > new file mode 100644 > > > index 000000000000..2c5c5e2b6159 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > > > @@ -0,0 +1,64 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/remoteproc/ti,pru-consumer.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Common TI PRU Consumer Binding > > > + > > > +maintainers: > > > + - Suman Anna <s-anna@xxxxxx> > > > + > > > +description: | > > > + A PRU application/consumer/user node typically uses one or more PRU device > > > + nodes to implement a PRU application/functionality. Each application/client > > > + node would need a reference to at least a PRU node, and optionally define > > > + some properties needed for hardware/firmware configuration. The below > > > + properties are a list of common properties supported by the PRU remoteproc > > > + infrastructure. > > > + > > > + The application nodes shall define their own bindings like regular platform > > > + devices, so below are in addition to each node's bindings. > > > + > > > +properties: > > > + prus: > > > > ti,prus > > Thank you - I will change and post v2 but with this I will run into > issues when this binding will be referenced by some consumer YAML > binding. Running dtbs_check in such case throws: > ... k3-am654-base-board.dt.yaml: serial@28000: 'ti,prus' does not > match any of the regexes: 'pinctrl-[0-9]+' > In the same time if I will remove this property from that node I am getting: > ... k3-am654-base-board.dt.yaml: serial@28000: 'ti,prus' is a required property > as expected. Sounds like you didn't update 'ti,prus' in whatever schema you include this one from. > > Getting rid of the comma from this property name workarounds mentioned > problem (which is not proper but allows me to correctly test this > binding): e.g. s/ti,prus/ti-pruss/ or using the previous name without > a comma. > It seems to be an issue with dtbs_check itself which we will encounter > in the future. If not, can you point me to a branch having this problem. Rob
