On Sat, Nov 21, 2020 at 7:50 AM Mathieu Poirier <mathieu.poirier@xxxxxxxxxx> wrote: > > Here you are breaking all the current implementation with a firmware image that > doesn't have a .ipi_buffer section name. I'm not against this change but you need > to make sure you don't break anything else with your changes. Thanks for your review. And yes, this change could break MTK SCP when working with legacy firmware. We'll make sure the new firmware in MT8183 also contains the .ipi_buffer section to not really break anything.