On Wed 25 May 04:13 PDT 2016, Stanimir Varbanov wrote: > On 03/29/2016 06:37 AM, Bjorn Andersson wrote: > > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> > > > > This introduces the peripheral image loader, for loading WCNSS firmware > > and boot the core on e.g. MSM8974. The firmware is verified and booted > > with the help of the Peripheral Authentication System (PAS) in > > TrustZone. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > --- > > > > Changes since v1: > > - Split iris definition into separate driver/dt-node > > - Move constants from DT to code > > - Make stop-state and some of interrupts optional to properly work on 8064 > > - Cleaned up and made mdt loader support relocation, which is needed on 8016. > > > > drivers/remoteproc/Kconfig | 12 + > > drivers/remoteproc/Makefile | 2 + > > drivers/remoteproc/qcom_mdt_loader.c | 172 +++++++++++ > > drivers/remoteproc/qcom_mdt_loader.h | 7 + > > drivers/remoteproc/qcom_wcnss.c | 579 +++++++++++++++++++++++++++++++++++ > > drivers/remoteproc/qcom_wcnss.h | 22 ++ > > drivers/remoteproc/qcom_wcnss_iris.c | 185 +++++++++++ > > 7 files changed, 979 insertions(+) > > create mode 100644 drivers/remoteproc/qcom_mdt_loader.c > > create mode 100644 drivers/remoteproc/qcom_mdt_loader.h > > create mode 100644 drivers/remoteproc/qcom_wcnss.c > > create mode 100644 drivers/remoteproc/qcom_wcnss.h > > create mode 100644 drivers/remoteproc/qcom_wcnss_iris.c > > > > <cut> > > > + > > +static int wcnss_remove(struct platform_device *pdev) > > +{ > > + struct qcom_wcnss *wcnss = platform_get_drvdata(pdev); > > + > > + of_platform_depopulate(&pdev->dev); > > + > > + qcom_smem_state_put(wcnss->state); > > + rproc_put(wcnss->rproc); > > might be need to call rproc_del() too ? > You're correct. Thanks for having a look! Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html