On Wed, Jan 20, 2021 at 10:30 PM Martin Wilck <mwilck@xxxxxxxx> wrote:
>
> On Wed, 2021-01-20 at 13:33 +0800, Zhu Yanjun wrote:
> > On Tue, 2021-01-19 at 20:10 +0800, Zhu Yanjun wrote:
> > > On Tue, Jan 19, 2021 at 6:57 PM <mwilck@xxxxxxxx> wrote:
> > >
> >
> > > My test scenario which is broken by your patch uses a script that
> > > does
> > > roughly the following:
> >
> > > # (set up eth0)
> > > rdma link add rxe_eth0 type rxe netdev eth0
> > > ip link add link eth0 name eth0.10 type vlan id 10
> > > ip link set eth0.10 up
> > > ip addr add 192.168.10.102/24 dev eth0.10
> >
> > Thanks a lot.
> > It seems that the vlan SKBs also enter RXE.
> >
> > There are 3 hunks in the commit b2d2440430c0("RDMA/rxe: Remove VLAN
> > code leftovers from RXE").
> >
> > Can you make more research to find out which hunk causes this
> > problem?
>
> I'm positive they all need to be reverted. It's not much code
> altogether that is removed, but this much is necessary to make VLANs
RXE does not support VLAN now.
> work.
>
> >
> > From Jason, vlan is not supported now.
> > If you want to make more work, the link
> > https://www.spinics.net/lists/linux-rdma/msg94737.html can give some
> > tips.
>
> That's fd49ddaf7e26. Did you notice that I referenced that commit in my
> patch description and actually said it was "absolutely correct"?
>
> Anyway, quoting from Mohammad's email: "therefore RXE must behave the
> same like HW-RoCE devices and create rxe device per real device only".
> This is exactly how the code behaved before your patch was applied.
> Or what am I missing?
>
> I have no experience with HW-RoCE. If it's true that RDMA is setup only
> "per real device only" there, why would the same thing be wrong for
> SW-RoCE?
>
>
> Martin
>
>
