On Fri, Oct 30, 2020 at 07:39:34PM +0800, Weihang Li wrote:
> HIP09 supports service type of Unreliable Datagram, add necessary process
> to enable this feature.
>
> Signed-off-by: Weihang Li <liweihang@xxxxxxxxxx>
> drivers/infiniband/hw/hns/hns_roce_device.h | 2 ++
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 8 +++++---
> drivers/infiniband/hw/hns/hns_roce_qp.c | 3 ++-
> 3 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_device.h b/drivers/infiniband/hw/hns/hns_roce_device.h
> index 9a032d0..23f8fe7 100644
> +++ b/drivers/infiniband/hw/hns/hns_roce_device.h
> @@ -222,7 +222,9 @@ enum {
> HNS_ROCE_CAP_FLAG_FRMR = BIT(8),
> HNS_ROCE_CAP_FLAG_QP_FLOW_CTRL = BIT(9),
> HNS_ROCE_CAP_FLAG_ATOMIC = BIT(10),
> + HNS_ROCE_CAP_FLAG_UD = BIT(11),
Why add this flag if nothing reads it?
> HNS_ROCE_CAP_FLAG_SDI_MODE = BIT(14),
> +
> };
Extra space
If I recall properly earlier chips did not have a GID table so could
not support UD because they could not secure the AH, or something like
that.
So, I would expect to see that only the new devices support UD, but
I can't quite see that in this patch??
Jason
