another change breaks rxe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jason,

commit 628c02bf38aa42c09c3dde61284ba348290e6650
Author: Jason Gunthorpe <jgg@xxxxxxxx>
Date:   Sat Oct 3 20:20:10 2020 -0300

    RDMA: Remove uverbs cmds from drivers that don't use them
    
    Allowing userspace to invoke these commands is probably going to crash
    these drivers as they are not tested and not expecting to use them on a
    user object.
    
    For example pvrdma touches cq->ring_state which is not initialized for
    user QPs.
    
    These commands are effected:
    
    - IB_USER_VERBS_CMD_REQ_NOTIFY_CQ is ibv_cmd_req_notify_cq() in
      rdma-core, only hfi1, ipath and rxe calls it.
    
    - IB_USER_VERBS_CMD_POLL_CQ is ibv_cmd_poll_cq() in rdma-core, only
      ipath and hfi1 calls it.
    
    - IB_USER_VERBS_CMD_POST_SEND/RECV is ibv_cmd_post_send/recv() in
      rdma-core, only ipath and hfi1 call them.

breaks rxe because it does use IB_USER_VERBS_CMD_POST_SEND. rxe posts wqes to a work queue in shared memory and then calls ibv_post_send with zero wqes as a doorbell to the kernel which uses this as a hint to go read the shared memory.

Bob



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux