On 10/8/20 6:33 PM, Jason Gunthorpe wrote:
> On Thu, Oct 08, 2020 at 03:36:52PM -0500, Bob Pearson wrote:
>> - The changes referenced below replaced sbk_clone by
>> taking additional references, passing the skb along and
>> then freeing the skb. This deleted the packets before
>> they could be processed and additionally passed bad data
>> in each packet. Since pkt is stored in skb->cb
>> changing pkt->qp changed it for all the packets.
>> - Replace skb_get by sbk_clone in rxe_rcv_mcast_pkt for
>> cases where multiple QPs are receiving multicast packets
>> on the same address.
>> - Delete kfree_skb because the packets need to live until
>> they have been processed by each QP. They are freed later.
>>
>> Signed-off-by: Bob Pearson <rpearson@xxxxxxx>
>> Fixes: 86af61764151 ("IB/rxe: remove unnecessary skb_clone")
>> Fixes: fe896ceb5772 ("IB/rxe: replace refcount_inc with skb_get")
>
> Fixes lines go before the Signed-off-by
>
> Makes sense to me, applied to for-next
>
> Thanks,
> Jasno
>
Thanks.
