On 10/8/20 6:16 PM, Jason Gunthorpe wrote:
> On Thu, Oct 08, 2020 at 04:28:18PM -0500, Bob Pearson wrote:
>
> Subject should be of the form
>
> RDMA/rxe: Some subject
>
> RDMA convention is to capitalize the first letter ie 'Some'
>
>> - Struct rxe_mem had pd, lkey and rkey values both in itself
>> and in the struct ib_mr which is also included in rxe_mem.
>> - Delete these entries and replace references with ones in ibmr.
>> - Add mr_lkey and mr_rkey macros which extract these values from mr.
>> - Added mr_pd macro which extracts pd from mr.
>
> Commit body text should be paragraphs not point form
>
>> @@ -333,6 +329,10 @@ struct rxe_mc_grp {
>> u16 pkey;
>> };
>>
>> +#define mr_pd(mr) to_rpd((mr)->ibmr.pd)
>> +#define mr_lkey(mr) ((mr)->ibmr.lkey)
>> +#define mr_rkey(mr) ((mr)->ibmr.rkey)
>
> Try to avoid macros for implementing functions, I changed this to:
>
> +static inline struct rxe_pd *mr_pd(struct rxe_mem *mr)
> +{
> + return to_rpd(mr->ibmr.pd);
> +}
> +
> +static inline u32 mr_lkey(struct rxe_mem *mr)
> +{
> + return mr->ibmr.lkey;
> +}
> +
> +static inline u32 mr_rkey(struct rxe_mem *mr)
> +{
> + return mr->ibmr.rkey;
> +}
> +
>
> and fixed the other stuff, applied to for-next
>
> Thanks,
> Jason
>
Thanks for the style hints and applying the patch. Just guessing but I assume that in RDMA/somthing RDMA refers to the entire drivers/infiniband tree. The equivalent for user space is RDMA-CORE or rdma-core ??
Bob
