On Sun, Oct 04, 2020 at 02:02:52PM +0300, Gal Pressman wrote: > On 04/10/2020 2:20, Jason Gunthorpe wrote: > > diff --git a/drivers/infiniband/hw/efa/efa_verbs.c b/drivers/infiniband/hw/efa/efa_verbs.c > > index 191e0843f090c8..e3d9a5a5f4d992 100644 > > +++ b/drivers/infiniband/hw/efa/efa_verbs.c > > @@ -917,6 +917,9 @@ int efa_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr, > > enum ib_qp_state new_state; > > int err; > > > > + if (qp_attr_mask & ~IB_QP_ATTR_STANDARD_BITS) > > + return -EOPNOTSUPP; > > This is kinda redundant, we have a more strict check in efa_modify_qp_validate. Okay Thanks, Jason
