On Sun, Oct 04, 2020 at 02:04:17PM +0300, Gal Pressman wrote:
> On 04/10/2020 2:20, Jason Gunthorpe wrote:
> > diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
> > index 418d133a8fb080..2f3f9b87922e92 100644
> > +++ b/drivers/infiniband/core/uverbs_cmd.c
> > @@ -3753,7 +3753,7 @@ const struct uapi_definition uverbs_def_write_intf[] = {
> > IB_USER_VERBS_EX_CMD_MODIFY_CQ,
> > ib_uverbs_ex_modify_cq,
> > UAPI_DEF_WRITE_I(struct ib_uverbs_ex_modify_cq),
> > - UAPI_DEF_METHOD_NEEDS_FN(create_cq))),
> > + UAPI_DEF_METHOD_NEEDS_FN(modify_cq))),
>
> Good catch, but is it related to this patch?
Yes, previously the uverbs_ex_cmd_mask of
IB_USER_VERBS_EX_CMD_MODIFY_CQ prevented this typo from mattering as
no driver set both the bit and a null ops.
This patch has drivers setting null ops with the bit set, so it must
be fixed now.
Jason
