Re: [PATCH rdma-next v2 1/4] IB/core: Improve ODP to use hmm_range_fault()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/30/2020 3:35 AM, Jason Gunthorpe wrote:

In addition to my previous note here as of below [1], ignoring the clear
error case might break some testing that expects to get an error in this
case when the contract was not honored.
The error code should be preserved, but not all callers care, like
prefetch for instance

Right, but for now we have a single caller (i.e. pagefault_real_mr) which doesn't know in the general case whether it was a prefetch. This can be considered as of some future improvement that should be handled carefully, I prefer in this stage to stay with previous behavior in this area.

Please send an update tomorre with these small changes since it is
late for me now

Jason

Sure, V3 may be sent soon, thanks for your feedback.

Yishai




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux