On Fri, Sep 18, 2020 at 08:30:11PM -0300, Jason Gunthorpe wrote: > On Mon, Sep 07, 2020 at 03:21:52PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > Special QPs (SMI and GSI) have different rules in regards of their QP > > numbers. While all other QP numbers are unique per-device, the QP0 and QP1 > > are created per-port as requested by IBTA. > > > > In multiple port devices, the number of SMI and GSI QPs with be equal > > to the number ports. > > > > [leonro@vm ~]$ rdma dev > > 0: ibp0s9: node_type ca fw 4.4.9999 node_guid 5254:00c0:fe12:3455 sys_image_guid 5254:00c0:fe12:3455 > > [leonro@vm ~]$ rdma link > > 0/1: ibp0s9/1: subnet_prefix fe80:0000:0000:0000 lid 13397 sm_lid 49151 lmc 0 state ACTIVE physical_state LINK_UP > > 0/2: ibp0s9/2: subnet_prefix fe80:0000:0000:0000 lid 13397 sm_lid 49151 lmc 0 state UNKNOWN physical_state UNKNOWN > > > > Before: > > [leonro@mtl-leonro-l-vm ~]$ rdma res show qp type SMI,GSI > > link ibp0s9/1 lqpn 0 type SMI state RTS sq-psn 0 comm [ib_core] > > link ibp0s9/1 lqpn 1 type GSI state RTS sq-psn 0 comm [ib_core] > > > > After: > > [leonro@vm ~]$ rdma res show qp type SMI,GSI > > link ibp0s9/1 lqpn 0 type SMI state RTS sq-psn 0 comm [ib_core] > > link ibp0s9/1 lqpn 1 type GSI state RTS sq-psn 0 comm [ib_core] > > link ibp0s9/2 lqpn 0 type SMI state RTS sq-psn 0 comm [ib_core] > > link ibp0s9/2 lqpn 1 type GSI state RTS sq-psn 0 comm [ib_core] > > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > --- > > drivers/infiniband/core/core_priv.h | 2 ++ > > drivers/infiniband/core/restrack.c | 11 +++++++++-- > > 2 files changed, 11 insertions(+), 2 deletions(-) > > Isn't this a pretty good stand alone bug fix? Add a fixes line? I see this patch as part of this series, and have no idea if it works as standalone fix that can be taken automatically to the stable@ by autosel bot later. Thanks > > Jason