From: Leon Romanovsky <leonro@xxxxxxxxxx> Changelog: v2: * Added new patch to fix mlx4 failure on SR-IOV, it didn't have port set. * Changed "RDMA/cma: Delete from restrack DB after successful destroy" patch. v1: * Fixed rebase error, deleted second assignment of qp_type. * Rebased code on latests rdma-next, the changes in cma.c caused to change in patch "RDMA/cma: Delete from restrack DB after successful destroy". * Dropped patch of port assignment, it is already done as part of this series. * I didn't add @calller description, regular users should not use _named() funciton. * https://lore.kernel.org/lkml/20200830101436.108487-1-leon@xxxxxxxxxx v0: https://lore.kernel.org/lkml/20200824104415.1090901-1-leon@xxxxxxxxxx ---------------------------------------------------------------------------------- Hi, The resource tracker has built-in kref counter to synchronize object release. It makes restrack perfect choice to be responsible for the memory lifetime of any object in which restrack entry is embedded. In order to make it, the restrack was changed to be mandatory and all callers of rdma_restrack_add() started to rely on result returned from that call. Being mandatory means that all objects specific to restrack type must be tracked. Before this series, the restrack and rdmatool were aid tools in debug session of user space applications, this caused to some of the functionality to be left behind, like support XRC QPs, device memory MRs and QP0/QP1 in multi-port devices. This series fixes all mentioned above without extending rdmatool at all. Thanks Leon Romanovsky (14): RDMA/cma: Delete from restrack DB after successful destroy RDMA/mlx5: Don't call to restrack recursively RDMA/mlx4: Provide port number for special QPs RDMA/restrack: Count references to the verbs objects RDMA/restrack: Simplify restrack tracking in kernel flows RDMA/restrack: Improve readability in task name management RDMA/cma: Be strict with attaching to CMA device RDMA/core: Allow drivers to disable restrack DB RDMA/counter: Combine allocation and bind logic RDMA/restrack: Store all special QPs in restrack DB RDMA/restrack: Make restrack DB mandatory for IB objects RDMA/restrack: Support all QP types RDMA/core: Track device memory MRs RDMA/restrack: Drop valid restrack field as source of ambiguity drivers/infiniband/core/cma.c | 225 +++++++++++------- drivers/infiniband/core/core_priv.h | 39 ++- drivers/infiniband/core/counters.c | 178 +++++++------- drivers/infiniband/core/cq.c | 24 +- drivers/infiniband/core/rdma_core.c | 3 +- drivers/infiniband/core/restrack.c | 207 ++++++++-------- drivers/infiniband/core/restrack.h | 10 +- drivers/infiniband/core/uverbs_cmd.c | 50 +++- drivers/infiniband/core/uverbs_std_types_cq.c | 12 +- drivers/infiniband/core/uverbs_std_types_mr.c | 10 + drivers/infiniband/core/uverbs_std_types_qp.c | 4 +- drivers/infiniband/core/verbs.c | 91 +++++-- drivers/infiniband/hw/mlx4/mad.c | 9 +- drivers/infiniband/hw/mlx5/gsi.c | 16 +- drivers/infiniband/hw/mlx5/qp.c | 2 +- include/rdma/ib_verbs.h | 10 +- include/rdma/restrack.h | 46 ++-- 17 files changed, 541 insertions(+), 395 deletions(-) -- 2.26.2
