On 2020/9/18 21:47, Jason Gunthorpe wrote:
> On Wed, Sep 09, 2020 at 04:57:26PM +0800, Weihang Li wrote:
>>
>> + ret = set_ud_opcode(ud_sq_wqe, wr);
>> + if (unlikely(ret)) {
>> + ibdev_err(ibdev, "unsupported opcode, opcode = %d.\n",
>> + wr->opcode);
>
> No random prints like this. If this is kernel only and something
> in-kernel is busted then it is just
>
> if (WARN_ON(ret))
>
> Same for every place in this patch
>
> Jason
>
Thanks for you suggestion, I will modify them.
Weihang
