Re: [PATCH v2 for-next 1/9] RDMA/hns: Refactor process about opcode in post_send()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 09, 2020 at 04:57:26PM +0800, Weihang Li wrote:
>  
> +	ret = set_ud_opcode(ud_sq_wqe, wr);
> +	if (unlikely(ret)) {
> +		ibdev_err(ibdev, "unsupported opcode, opcode = %d.\n",
> +			  wr->opcode);

No random prints like this. If this is kernel only and something
in-kernel is busted then it is just

  if (WARN_ON(ret))

Same for every place in this patch

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux