Re: [PATCH for-next v5 09/12] rdma_rxe: Add support for extended QP operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 18, 2020 at 04:15:14PM -0500, Bob Pearson wrote:
> Add bits to user api command bitmask.
> 
> Signed-off-by: Bob Pearson <rpearson@xxxxxxx>
>  drivers/infiniband/sw/rxe/rxe_verbs.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> index 594d8353600a..7849d8d72d4c 100644
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> @@ -1187,6 +1187,8 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name)
>  
>  	dev->uverbs_ex_cmd_mask =
>  	      BIT_ULL(IB_USER_VERBS_EX_CMD_QUERY_DEVICE)
> +	    | BIT_ULL(IB_USER_VERBS_EX_CMD_CREATE_QP)
> +	    | BIT_ULL(IB_USER_VERBS_EX_CMD_MODIFY_QP)
>  	    | BIT_ULL(IB_USER_VERBS_EX_CMD_CREATE_CQ)
>  	    | BIT_ULL(IB_USER_VERBS_EX_CMD_MODIFY_CQ)
>  	    ;

Again I wonder if we should just set these always in the core code,
can you see a reason why not?

I really hate these cmd_masks and want to get rid of them anyhow

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux