On Fri, Sep 18, 2020 at 04:15:12PM -0500, Bob Pearson wrote:
> Add code to initialize new struct members in
> ib_device_attr as place holders.
>
> Signed-off-by: Bob Pearson <rpearson@xxxxxxx>
> drivers/infiniband/sw/rxe/rxe.c | 101 ++++++++++++++++++--------
> drivers/infiniband/sw/rxe/rxe_verbs.c | 7 +-
> 2 files changed, 75 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
> index fab291245366..8d2be78e72ef 100644
> +++ b/drivers/infiniband/sw/rxe/rxe.c
> @@ -38,40 +38,77 @@ void rxe_dealloc(struct ib_device *ib_dev)
> /* initialize rxe device parameters */
> static void rxe_init_device_param(struct rxe_dev *rxe)
> {
> - rxe->max_inline_data = RXE_MAX_INLINE_DATA;
What actually changed here? Isn't dev_attr zero initialized?
> /* initialize port attributes */
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> index 21582507ed32..a77f2e0ef68f 100644
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> @@ -1149,7 +1149,8 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name)
> dma_coerce_mask_and_coherent(&dev->dev,
> dma_get_required_mask(&dev->dev));
>
> - dev->uverbs_cmd_mask = BIT_ULL(IB_USER_VERBS_CMD_GET_CONTEXT)
> + dev->uverbs_cmd_mask =
> + BIT_ULL(IB_USER_VERBS_CMD_GET_CONTEXT)
> | BIT_ULL(IB_USER_VERBS_CMD_CREATE_COMP_CHANNEL)
> | BIT_ULL(IB_USER_VERBS_CMD_QUERY_DEVICE)
> | BIT_ULL(IB_USER_VERBS_CMD_QUERY_PORT)
> @@ -1184,6 +1185,10 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name)
> | BIT_ULL(IB_USER_VERBS_CMD_DEALLOC_MW)
> ;
>
> + dev->uverbs_ex_cmd_mask =
> + BIT_ULL(IB_USER_VERBS_EX_CMD_QUERY_DEVICE)
> + ;
Hurm, I don't even know why we have this bit, did you see a reason?
Jason
